GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-105678: Split MAKE_FUNCTION into MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE by markshannon · Pull Request #105680 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The purpose of this PR is to simplify the stack effect of MAKE_FUNCTION to simplify our code generators and analysis.

This probably isn't the final version of MAKE_FUNCTION.
I expect that will take a variable number of cells, embedding the cells directly in the function object to avoid the indirection in accessing cells.

I've kept the same flags as before. SET_FUNCTION_ATTRIBUTE could be streamlined, but that's for another PR.

  • Issue: Remove irregular stack effects #105678

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Split MAKE_FUNCTION into MAKE_FUNCTION and SET_FUNCTION_ATTRIBUTE
d2ddf54
@markshannon
markshannon requested review from brettcannon, ericsnowcurrently, iritkatriel, ncoghlan and warsaw as code owners June 12, 2023 09:37
@bedevere-bot bedevere-bot added the awaiting core review label Jun 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
Remove irregular stack effects #105678
Closed
markshannon
markshannon commented Jun 12, 2023
View reviewed changes
Comment thread Lib/importlib/_bootstrap_external.py
# in PC/launcher.c must also be updated.

MAGIC_NUMBER = (3551).to_bytes(2, 'little') + b'\r\n'
MAGIC_NUMBER = (3554).to_bytes(2, 'little') + b'\r\n'

@markshannon markshannon Jun 12, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll set this to the correct value before merging.
The actual number will depend on which PRs get merged first.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
carljm
carljm approved these changes Jun 12, 2023
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think _Py_set_function_type_params intrinsic should probably be rolled into SET_FUNCTION_ATTRIBUTE also? But that could be a separate change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 12, 2023
@brettcannon
brettcannon removed their request for review June 12, 2023 22:55
@markshannon

markshannon commented Jun 13, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Once we handle closures in MAKE_FUNCTION we should either convert SET_FUNCTION_ATTRIBUTE into instrinsics or move the _Py_set_function_type_params into SET_FUNCTION_ATTRIBUTE. I suspect it will be the former, but it will depend on the numbers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 09ffa69 into python:main Jun 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 13, 2023
@carljm carljm mentioned this pull request Jun 16, 2023
gh-105678: document SET_FUNCTION_ATTRIBUTE #105843
Merged
@markshannon
markshannon deleted the simplify-make-function branch September 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @carljm @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.