GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104584: Assorted fixes for the optimizer API. by markshannon · Pull Request #105683 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes a few odds and ends found trying to fix #105682

  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 7 commits June 7, 2023 22:15
@markshannon
Fix optimizer API.
2335db6
@markshannon
Merge branch 'main' into fix-optimizer-api
e4c57d8
@markshannon
Add test for long loops
4a2ea94
@markshannon
Address review comments.
06345a6
@markshannon
Merge branch 'main' into fix-optimizer-api
c4107ae
@markshannon
Merge branch 'main' into fix-optimizer-api
a5eed25
@markshannon
Clear ENTER_EXECUTOR when deopting code objects.
18a4b7e
@bedevere-bot bedevere-bot added the awaiting core review label Jun 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 12, 2023
Pluggable optimizer API #104584
Closed
@markshannon markshannon added the skip news label Jun 12, 2023
carljm
carljm reviewed Jun 12, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_misc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_capi/test_misc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_capi/test_misc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher
brandtbucher self-requested a review June 12, 2023 17:25
brandtbucher
brandtbucher reviewed Jun 13, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to all of @carljm's comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/codeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/optimizer.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon added 2 commits June 15, 2023 02:43
@markshannon
Merge branch 'main' into fix-optimizer-api
6fac756
@markshannon
Fix merge artifact.
019a233
carljm
carljm approved these changes Jun 15, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_misc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 15, 2023
@markshannon
Remove useless comment
ff61b56
@gvanrossum

gvanrossum commented Jun 18, 2023

Copy link
Copy Markdown
Member

What's holding this up? I was playing around with the optimizer, trying to bootstrap a "hello world" version of a Tier 2 interpreter, and I need this to avoid crashes at exit (crashes that happened even without my changes).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 5816199 into python:main Jun 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2023
@markshannon
markshannon deleted the fix-optimizer-api branch June 19, 2023 09:32
@AlexWaygood AlexWaygood mentioned this pull request Jun 19, 2023
test_capi fails if run with --forever argument #105273
Closed
@erlend-aasland erlend-aasland mentioned this pull request Jun 19, 2023
./python -m test -v test_capi -m test_misc --forever fails. #105682
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments
@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

./python -m test -v test_capi -m test_misc --forever fails.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@markshannon @gvanrossum @carljm @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.