GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-105375: Explicitly initialise all {Pickler,Unpickler}Object fields (#105686) by erlend-aasland · Pull Request #105711 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

All fields must be explicitly initialised to prevent manipulation of
uninitialised fields in dealloc.

Align initialisation order with the layout of the object structs.

(cherry picked from commit ca3cc4b)

Co-authored-by: Erlend E. Aasland [email protected]

  • Issue: Incorrect error handling for APIs that can raise exceptions #105375

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@erlend-aasland
[3.11] pythongh-105375: Explicitly initialise all {Pickler,Unpickler}…
cba170e
…Object fields (python#105686)

All fields must be explicitly initialised to prevent manipulation of
uninitialised fields in dealloc.

Align initialisation order with the layout of the object structs.

(cherry picked from commit ca3cc4b)

Co-authored-by: Erlend E. Aasland <[email protected]>
@bedevere-bot bedevere-bot added the awaiting core review label Jun 12, 2023
This was referenced Jun 12, 2023
Incorrect error handling for APIs that can raise exceptions #105375
Closed
gh-105375: Explicitly initialise all {Pickler,Unpickler}Object fields #105686
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 12, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) June 12, 2023 21:52
@erlend-aasland
Fix cherry-pick
e40a0cf
@kumaraditya303
kumaraditya303 disabled auto-merge June 13, 2023 06:24
@kumaraditya303 kumaraditya303 closed this Jun 13, 2023
@kumaraditya303 kumaraditya303 reopened this Jun 13, 2023
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) June 13, 2023 06:24
@kumaraditya303

kumaraditya303 commented Jun 13, 2023

Copy link
Copy Markdown
Contributor

Retrigged CI

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 merged commit 36c393c into python:3.11 Jun 13, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 13, 2023
@erlend-aasland
erlend-aasland deleted the backport-3.11-fix-pickle-newgcobj branch June 13, 2023 07:05
@erlend-aasland

erlend-aasland commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

Thanks, Kumar!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.