GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-104812: Run Pending Calls in any Thread (gh-104813) by ericsnowcurrently · Pull Request #105752 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 13, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For a while now, pending calls only run in the main thread (in the main interpreter). This PR changes things to allow any thread run a pending call, unless the pending call was explicitly added for the main thread to run.
(cherry picked from commit 757b402)

  • Issue: Subinterpreter Pending Calls Never Run  #104812

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently
ericsnowcurrently requested review from markshannon and rhettinger as code owners June 13, 2023 21:55
@bedevere-bot bedevere-bot added the awaiting core review label Jun 13, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 5, 2023
Subinterpreter Pending Calls Never Run #104812
Closed
@ericsnowcurrently
ericsnowcurrently removed request for markshannon and rhettinger June 13, 2023 21:55
@bedevere-bot bedevere-bot mentioned this pull request Jun 13, 2023
gh-104812: Run Pending Calls in any Thread #104813
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 13, 2023
@ericsnowcurrently
pythongh-104812: Run Pending Calls in any Thread (pythongh-104813)
f95336b
For a while now, pending calls only run in the main thread (in the main interpreter).  This PR changes things to allow any thread run a pending call, unless the pending call was explicitly added for the main thread to run.
@ericsnowcurrently
ericsnowcurrently force-pushed the per-interpreter-pending-calls-backport-3.12 branch from 0fb86c7 to f95336b Compare June 13, 2023 21:56
@ericsnowcurrently
Update python3.12.abi
2beb1d3
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jun 14, 2023
gh-104812: Skip Pending Calls Tests if No Threading #105761
Merged
@ericsnowcurrently
Skip tests if no threading.
a0786b8
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) June 14, 2023 00:22
@ericsnowcurrently
ericsnowcurrently merged commit 33d3069 into python:3.12 Jun 14, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 14, 2023
@ericsnowcurrently
ericsnowcurrently deleted the per-interpreter-pending-calls-backport-3.12 branch June 14, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.