GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105751: test_ctypes avoids "from ctypes import *" by vstinner · Pull Request #105768 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Using "import *" prevents linters like pyflakes to detect symbols (variables, functions) used being imported.

Replace c_voidp with c_void_p.

  • Issue: Rework test_ctypes #105751

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105751: test_ctypes avoids "from ctypes import *"
c640c34 
Using "import *" prevents linters like pyflakes to detect symbols
(variables, functions) used being imported.

Replace c_voidp with c_void_p.
@vstinner vstinner added the skip news label Jun 14, 2023
@vstinner
vstinner requested a review from rhettinger as a code owner June 14, 2023 02:52
@bedevere-bot bedevere-bot added the awaiting core review label Jun 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 14, 2023
Rework test_ctypes #105751
Closed
@vstinner
vstinner enabled auto-merge (squash) June 14, 2023 03:05
vstinner added 2 commits June 14, 2023 05:07
@vstinner
Add missing import
a2d6407
@vstinner
Remove duplicated import
887a8dc
@vstinner
vstinner disabled auto-merge June 14, 2023 03:09
@vstinner
vstinner enabled auto-merge (squash) June 14, 2023 03:10
@vstinner
vstinner merged commit b95de96 into python:main Jun 14, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 14, 2023
@vstinner
vstinner deleted the test_ctypes_explicit_import branch June 27, 2023 23:17
@max-muoto max-muoto mentioned this pull request Jul 20, 2024
Resolve 3.13 issues for ctypes._endian python/typeshed#12372
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.