GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-105793: Add follow_symlinks argument to `pathlib.Path.is_dir()` and `is_file()` by barneygale · Pull Request #105794 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Brings pathlib.Path.is_dir() in line with os.DirEntry.is_dir(), likewise is_file(), which will be important for implementing generic path walking and globbing.

  • Issue: Support for not following symlinks in pathlib.Path.is_dir() #105793

📚 Documentation preview 📚: https://cpython-previews--105794.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-105793: Add follow_symlinks argument to pathlib.Path.is_dir()
7c2c51a 
Brings `pathlib.Path.is_dir()` in line with `os.DirEntry.is_dir()`, which
will be important for implementing generic path walking and globbing.
@barneygale barneygale added the topic-pathlib label Jun 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 14, 2023
Support for not following symlinks in pathlib.Path.is_dir() #105793
Closed
@barneygale
barneygale marked this pull request as ready for review June 14, 2023 18:19
@bedevere-bot bedevere-bot added the awaiting core review label Jun 14, 2023
barneygale added 2 commits June 15, 2023 04:51
@barneygale
Merge branch 'main' into pythongh-105793-is-dir-follow-symlinks
1323b7a
@barneygale
Also add argument to is_file().
1f66670
@barneygale barneygale changed the title GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() GH-105793: Add follow_symlinks argument to pathlib.Path.is_dir() and is_file() Jun 15, 2023
EpicWink
EpicWink approved these changes Jun 18, 2023
View reviewed changes
barneygale added 3 commits June 18, 2023 18:20
@barneygale
Add whatsnew entry
235def1
@barneygale
Fix typo
8dc7513
@barneygale
Merge branch 'main' into pythongh-105793-is-dir-follow-symlinks
a1a7039
@barneygale

barneygale commented Jun 24, 2023

Copy link
Copy Markdown
Contributor Author

@zooba would you be up for reviewing this? It's similar to #102616, and necessary for a pathlib.AbstractPath or tarfile.TarPath to support globbing. Thank you, no worries if not!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Merge branch 'main' into pythongh-105793-is-dir-follow-symlinks
b248777
zooba
zooba approved these changes Jun 26, 2023
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 26, 2023
@barneygale
barneygale merged commit 219effa into python:main Jun 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2023
@barneygale barneygale mentioned this pull request Oct 10, 2023
ArtifactoryPath.glob() failing on Python versions >= 3.11.4 devopshq/artifactory#432
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
+1 more reviewer
@EpicWink EpicWink EpicWink approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@barneygale @zooba @EpicWink @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.