GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-105834: Backport new tests for `typing.Protocol` (#105835) by AlexWaygood · Pull Request #105860 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jun 16, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry-picked from commit 70c075c)

This actually backports some adjacent tests as well, which currently exist on main and 3.12 but not on 3.11. These tests weren't part of #105835, but (1) the tests all pass on 3.11; (2) more test coverage never hurts; and (3) backporting these tests will reduce the risk of merge conflicts when backporting test-only PRs in the future.

  • Issue: Untested code in typing.py #105834

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood and others added 2 commits June 16, 2023 17:02
@AlexWaygood
[3.11] pythongh-105834: Add tests for calling issubclass() between …
7a3b537 
…two protocols (python#105835)

Some parts of the implementation of `typing.Protocol` had poor test coverage
@AlexWaygood
Add missing import
e1d3326
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 16, 2023 16:11
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 16, 2023
This was referenced Jun 16, 2023
Untested code in typing.py #105834
Closed
gh-105834: Add tests for calling issubclass() between two protocols #105835
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 16, 2023
JelleZijlstra
JelleZijlstra approved these changes Jun 16, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 16, 2023
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) June 16, 2023 16:24
@JelleZijlstra
JelleZijlstra merged commit e590338 into python:3.11 Jun 16, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 16, 2023
@AlexWaygood
AlexWaygood deleted the backport-105835-311 branch June 16, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.