GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104212: Explain how to port imp.load_source() by vstinner · Pull Request #105951 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 20, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Explain how to port removed imp "load" functions to Python 3.13 in What's New in Python 3.12.

  • Issue: Improve the docs regarding the migration from imp to importlib  #104212

📚 Documentation preview 📚: https://cpython-previews--105951.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-104212: Explain how to port imp.load_source()
701629f
Explain how to port removed imp "load" functions to Python 3.13 in
What's New in Python 3.12.
@vstinner vstinner added the skip news label Jun 20, 2023
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir labels Jun 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 20, 2023
Improve the docs regarding the migration from imp to importlib #104212
Closed
@vstinner vstinner added the needs backport to 3.12 only security fixes label Jun 20, 2023
@vstinner vstinner mentioned this pull request Jun 20, 2023
gh-104212: Add importlib.util.load_source_path() function #105755
Closed
@vstinner
move load_dynamic before
66dba52
@brettcannon
brettcannon self-requested a review June 20, 2023 23:31
@vstinner

vstinner commented Jun 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I'm not comfortable to add such wall of text just to update code using imp in What's New in Python 3.12. I'm not convinced that init_builtin() or load_dynamic() are commonly used. These functions are more like internal functions used by the imp.load_module() function.

Moreover, I'm not sure how find_module() was used with load_module() to load modules. Is the use case to specify a search path which is not in sys.path? Why not putting the path in sys.path and simply use importlib.import_module()?

But I still consider that imp.load_source() is different and remains a relevant use case on its own. So I proposed PR #105978 to just document a recipe to replace this one.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner closed this Jun 21, 2023
@vstinner
vstinner deleted the load_source_doc branch June 21, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir needs backport to 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.