GeezerVison

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@sobolevn @zooba (as recent committers into Lib/webbrowser.py)

tested on linux with

• chromium
• firefox
• epiphany

opera opens automatically with a private tab.
konqueror seams not offer such a feature.

i would suggest that someone else will do auto formatting with black (PEP08)

i followed the approach of the given tests under Lib/test/test_webbrowser.py and added some more for parameter checking (as far i understood that is how it works).

but since even the original tests i can not run here on my local machine (3 are failing) i created now a gist rather than releasing it.

https://gist.github.com/kr-g/95a06df8f0fcf77ad10474724350e921

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

it is possible to fetch the PR to a local repo.

in case you dont know how:

please follow up here https://github.com/progit/progit2/releases -> search for "Pull Request Refs" (in release 2.1.404 it is from page 196 onwards).

the next section "Pull Requests on Pull Requests" describes how depending changes/ extensions can be made.

so ... for any other browser not covered so far (like e.g. MacOSXOSAScript mentioned by @ronaldoussoren) ... it would be great if the "finder" of that gap could provide also some code here.

Thanks

I fetched the this PR and I made some changes, but now how can I make the PR on this PR ?

Thanks for the update! Some things still to do (I unresolved the relevant threads):

• Don't fallback to open_new, raise an exception instead
• Remove -b and -l options
• "Incognito" is more of a Google Chrome name, let's primarily name as "private", but can also mention "incognito" to help when searching (I can't seem to find where I earlier commented this...)

@kr-g There's not much point updating this branch from main unless the unresolved items are addressed.

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

i use the branch - therefore i merge from time to time.
i m aware that you dont.
there is no reason to tell that in addition.
just unsubscribe. thanks.

@kr-g As mentioned, there's no point updating this PR from main unless the other issues are going to be resolved. Otherwise we let's close this, and we can re-open it when those issues have been addressed.

but anyway good to know the intention to kick me out of my own code.

Hi @kr-g, we have no intention of kicking you out of your own code :) However, by keeping a PR open against the CPython repo, you are indicating that this patch is something you are actively seeking to be merged into the main branch, and would like CPython maintainers to engage with. If you are not interested in addressing the comments of the reviewers here, that is your right, but you cannot expect for this PR to be kept open indefinitely.

If the PR is closed, the branch will not be deleted, and you will be able to continue using it locally. You will not be kicked out of your own code in any way. However, the PR will no longer show up as an active, open PR against the CPython repo that maintainers should engage with and attempt to review.

It sounds as though you are currently uninterested in addressing the comments of the reviewers here, so I'm going to close this. If I'm incorrect, and you are still interested in having this patch merged into the CPython main branch, please let us know, and we can reopen the PR :)

i already said it some months ago that i see the "experts" here in charge to take over those topics because from my point of view thats an integration (or migration) issue to split the PR or rename a feature. i m not an expert and dont know what fits best on cpython baseline. but somehow this turns out to be ... well anyone can read and have an own idea about it.
there is no need to discuss further. also these lines are already too much.

CPython is an open-source project maintained by volunteers, who have limited time to help PRs make it over the finish line. I'm afraid it's the responsibility of the author of the PR to ensure that it's of a quality suitable to be merged, not the responsibility of the CPython core developers. We've given you advice on the changes that would be required to get this into a state where it could be merged; in this instance, that's as much as we can do.

since i have doubled the webbrowser code already in my own project that all is not of importance to me. in case it comes somewhere in time i dont bother.
but as of today i m pissed off by the time used for this all.
i unsubscribe now from this thread and delete the repo on my side.
if someone whats to pick up the last word, or write sort of poetry. thats also fine with me.