GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105927: Avoid calling PyWeakref_GET_OBJECT() by vstinner · Pull Request #105997 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Replace PyWeakref_GET_OBJECT() with _PyWeakref_GET_REF().
  • _sqlite/blob.c now holds a strong reference to the blob object while calling close_blob().
  • _xidregistry_find_type() now holds a strong reference to registered while using it.
  • Issue: C API: Add PyWeakref_GetRef() function #105927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105927: Avoid calling PyWeakref_GET_OBJECT()
0f4ba32 
* Replace PyWeakref_GET_OBJECT() with _PyWeakref_GET_REF().
* _sqlite/blob.c now holds a strong reference to the blob object
  while calling close_blob().
* _xidregistry_find_type() now holds a strong reference to registered
  while using it.
@vstinner vstinner added the skip news label Jun 22, 2023
@vstinner
vstinner requested review from berkerpeksag and erlend-aasland as code owners June 22, 2023 19:56
@bedevere-bot bedevere-bot added the awaiting core review label Jun 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2023
C API: Add PyWeakref_GetRef() function #105927
Closed
@vstinner
vstinner merged commit 46a3190 into python:main Jun 22, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 22, 2023
@vstinner
vstinner deleted the getref_obj branch June 22, 2023 20:31
@vstinner vstinner mentioned this pull request Jun 23, 2023
gh-105927: Add _PyWeakref_IS_DEAD() function #105992
Merged
erlend-aasland
erlend-aasland reviewed Jun 26, 2023
View reviewed changes
Comment thread Modules/_sqlite/blob.c
PyObject *blob = PyWeakref_GetObject(weakref);
if (!Py_IsNone(blob)) {
close_blob((pysqlite_Blob *)blob);
PyObject *blob = _PyWeakref_GET_REF(weakref);

@erlend-aasland erlend-aasland Jun 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we should use public API only in the sqlite3 extension module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 26, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hesitated to use PyWeakref_GetRef() but pysqlite_close_all_blobs() cannot report errors (return type is void), and I hesitated to use PyErr_WriteUnraisable().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.