GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105922: Use PyImport_AddModuleRef() function by vstinner · Pull Request #105999 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyImport_AddModuleObject() + Py_XNewRef() with PyImport_AddModuleRef() to get directly a strong reference.

  • Issue: C API: Add PyImport_AddModuleRef() function #105922

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105922: Use PyImport_AddModuleRef() function
57b2b7b 
Replace PyImport_AddModuleObject() + Py_XNewRef() with
PyImport_AddModuleRef() to get directly a strong reference.
@vstinner
vstinner requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners June 22, 2023 20:33
@bedevere-bot bedevere-bot added the awaiting core review label Jun 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2023
C API: Add PyImport_AddModuleRef() function #105922
Closed
@vstinner vstinner added the skip news label Jun 22, 2023
@vstinner

vstinner commented Jun 22, 2023

Copy link
Copy Markdown
Member Author

test_threading failed with a warning on the Address sanitizer CI:

test_4_daemon_threads (test.test_threading.ThreadJoinOnShutdown.test_4_daemon_threads) ... ok
test_clear_threads_states_after_fork (test.test_threading.ThreadJoinOnShutdown.test_clear_threads_states_after_fork) ... ok
test_reinit_tls_after_fork (test.test_threading.ThreadJoinOnShutdown.test_reinit_tls_after_fork) ... Warning -- Uncaught thread exception: AssertionError
Exception in thread Thread-36 (do_fork_and_wait):
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 1052, in _bootstrap_inner
    self.run()
  File "/home/runner/work/cpython/cpython/Lib/threading.py", line 989, in run
    self._target(*self._args, **self._kwargs)
  File "/home/runner/work/cpython/cpython/Lib/test/test_threading.py", line 1173, in do_fork_and_wait
    support.wait_process(pid, exitcode=50)
  File "/home/runner/work/cpython/cpython/Lib/test/support/__init__.py", line 2156, in wait_process
    raise AssertionError(f"process {pid} is still running "
AssertionError: process 21364 is still running after 300.3 seconds
ok
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 193a2b2 into python:main Jun 22, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 22, 2023
@vstinner
vstinner deleted the add_module_ref branch June 22, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.