GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105927: _ssl GET_SOCKET() uses _PyWeakref_GET_REF() by vstinner · Pull Request #106002 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: C API: Add PyWeakref_GetRef() function #105927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105927: _ssl GET_SOCKET() uses _PyWeakref_GET_REF()
9c565c2
@vstinner vstinner added the skip news label Jun 22, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 22, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2023
C API: Add PyWeakref_GetRef() function #105927
Closed
@vstinner
vstinner merged commit 7b3ed5b into python:main Jun 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 23, 2023
@vstinner
vstinner deleted the getref_ssl branch June 23, 2023 01:02
@vstinner

vstinner commented Jun 23, 2023

Copy link
Copy Markdown
Member Author

I started hacking _ssl.c to use a strong reference, but the code is more complicated than what I expected. GET_SOCKET() returns NULL if there is no socket, None is the weak reference is dead, or a borrowed reference to the socket otherwise. It's not easy to migrate the code to strong references. So I only changed GET_SOCKET() but it still returns a borrowed reference.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.