GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105927: Deprecate PyWeakref_GetObject() function by vstinner · Pull Request #106006 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Deprecate PyWeakref_GetObject() and PyWeakref_GET_OBJECT() functions.

  • Issue: C API: Add PyWeakref_GetRef() function #105927

📚 Documentation preview 📚: https://cpython-previews--106006.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Jun 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2023
C API: Add PyWeakref_GetRef() function #105927
Closed
@vstinner

vstinner commented Jun 23, 2023

Copy link
Copy Markdown
Member Author

cc @erlend-aasland @encukou @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-105927: Deprecate PyWeakref_GetObject() function
5753693 
Deprecate PyWeakref_GetObject() and PyWeakref_GET_OBJECT() functions.
@vstinner
vstinner force-pushed the deprecate_weakref_getobject branch from cded796 to 5753693 Compare June 23, 2023 06:45
erlend-aasland
erlend-aasland reviewed Jun 26, 2023
View reviewed changes
Comment thread Modules/_testcapimodule.c
Comment on lines +3379 to +3380
_Py_COMP_DIAG_PUSH
_Py_COMP_DIAG_IGNORE_DEPR_DECLS

@erlend-aasland erlend-aasland Jun 26, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know these macros; TIL!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 26, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very useful to write tests on deprecated APIs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland
erlend-aasland approved these changes Jun 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 26, 2023
@vstinner
vstinner merged commit c075a19 into python:main Jun 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2023
@vstinner
vstinner deleted the deprecate_weakref_getobject branch June 26, 2023 10:10
@encukou

encukou commented Jun 26, 2023

Copy link
Copy Markdown
Member

Why 3.15? I don't see any reason to use the minimum allowed deprecation period here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 27, 2023

Copy link
Copy Markdown
Member Author

Why 3.15? I don't see any reason to use the minimum allowed deprecation period here.

Borrowed references as bad: see the issue for the rationale.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @encukou @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.