GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105927: Remove _PyWeakref_GetWeakrefCount() by vstinner · Pull Request #106007 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove _PyWeakref_GetWeakrefCount() and _PyWeakref_ClearRef() from the public C API: move them to the internal C API.

Refactor also _weakref_getweakrefs() code to make it more readable.

  • Issue: C API: Add PyWeakref_GetRef() function #105927

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105927: Remove _PyWeakref_GetWeakrefCount()
6a5c73f 
Remove _PyWeakref_GetWeakrefCount() and _PyWeakref_ClearRef() from
the public C API: move them to the internal C API.

Refactor also _weakref_getweakrefs() code to make it more readable.
@vstinner
vstinner requested a review from pablogsal as a code owner June 23, 2023 02:30
@bedevere-bot bedevere-bot added the awaiting core review label Jun 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2023
C API: Add PyWeakref_GetRef() function #105927
Closed
@vstinner vstinner added the skip news label Jun 23, 2023
@vstinner
vstinner enabled auto-merge (squash) June 23, 2023 02:58
@vstinner
vstinner merged commit 6a80664 into python:main Jun 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 23, 2023
@vstinner
vstinner deleted the weakref_internal_api branch June 27, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.