GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-89812: Make symlink support configurable in pathlib tests. by barneygale · Pull Request #106060 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jun 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adjust the pathlib tests to add a new PathTest.can_symlink class attribute, which allows us to enable or disable symlink support in tests. A (near-)future commit will add an AbstractPath class; its tests will hard-code the value to True or False depending on a stub subclass's capabilities.

  • Issue: Add tarfile.TarPath #89812

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-89812: Make symlink support configurable in pathlib tests.
35e7b04 
Adjust the pathlib tests to add a new `PathTest.can_symlink` class
attribute, which allows us to enable or disable symlink support in tests.
A (near-)future commit will add an `AbstractPath` class; its tests will
hard-code the value to `True` or `False` depending on a stub subclass's
capabilities.
@barneygale barneygale added tests Tests in the Lib/test dir skip news topic-pathlib labels Jun 24, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 24, 2023
Add tarfile.TarPath #89812
Open
@barneygale
Merge branch 'main' into pythongh-89812-pathlib-tests-can-symlink
f9bdd3a
CAM-Gerlach
CAM-Gerlach approved these changes Jun 30, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert, but the change seems reasonable, motivated and straightforward to me, and I didn't spot any obvious issues with the implementation reading through it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 30, 2023
@CAM-Gerlach

CAM-Gerlach commented Jun 30, 2023

Copy link
Copy Markdown
Member

You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows).
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Jun 30, 2023

Copy link
Copy Markdown
Contributor Author

You might want to consider running against the buildbot fleet if you thing there's a chance this might trigger any behavior difference on different platforms, given the previous platform dependent code (special casing windows).

Good idea! How do I do that? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2023
@bedevere-bot

bedevere-bot commented Jun 30, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @barneygale for commit f9bdd3a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2023
@barneygale
barneygale merged commit 3fd99b5 into python:main Jul 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@barneygale @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.