GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106084: Remove old PyObject call aliases by vstinner · Pull Request #106085 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 25, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove old aliases which were kept backwards compatibility with Python 3.8:

  • _PyObject_CallMethodNoArgs()
  • _PyObject_CallMethodOneArg()
  • _PyObject_CallOneArg()
  • _PyObject_FastCallDict()
  • _PyObject_Vectorcall()
  • _PyObject_VectorcallMethod()
  • _PyVectorcall_Function()

Update code which used these aliases to use new names.

  • Issue: C API: Remove private functions from abstract.h #106084

📚 Documentation preview 📚: https://cpython-previews--106085.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
vstinner requested review from brettcannon, corona10, ericsnowcurrently, markshannon, ncoghlan, rhettinger, tiran and warsaw as code owners June 25, 2023 16:02
@bedevere-bot bedevere-bot added the awaiting core review label Jun 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 25, 2023
C API: Remove private functions from abstract.h #106084
Closed
@vstinner
pythongh-106084: Remove old PyObject call aliases
f5b1f92
Remove old aliases which were kept backwards compatibility with
Python 3.8:

* _PyObject_CallMethodNoArgs()
* _PyObject_CallMethodOneArg()
* _PyObject_CallOneArg()
* _PyObject_FastCallDict()
* _PyObject_Vectorcall()
* _PyObject_VectorcallMethod()
* _PyVectorcall_Function()

Update code which used these aliases to use new names.
@vstinner
vstinner force-pushed the remove_deprecated_call_alias branch from a4c6cea to f5b1f92 Compare June 25, 2023 16:03
rhettinger
rhettinger approved these changes Jun 25, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 25, 2023
@vstinner
vstinner merged commit 00e75a3 into python:main Jun 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2023
@vstinner
vstinner deleted the remove_deprecated_call_alias branch June 26, 2023 06:08
@vstinner

vstinner commented Jun 26, 2023

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @rhettinger

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Jun 26, 2023

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM Raspbian 3.x has failed when building commit 00e75a3.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/424/builds/4273) and take a look at the build logs.
  4. Check if the failure is related to this commit (00e75a3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/424/builds/4273

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

426 tests OK.

10 slowest tests:

  • test_venv: 11 min 4 sec
  • test_largefile: 8 min 46 sec
  • test_multiprocessing_spawn: 6 min 30 sec
  • test_math: 4 min 27 sec
  • test_concurrent_futures: 3 min 12 sec
  • test_profile: 2 min 43 sec
  • test_webbrowser: 2 min 32 sec
  • test_cppext: 2 min 14 sec
  • test_hashlib: 2 min 12 sec
  • test_multiprocessing_forkserver: 2 min 1 sec

1 test altered the execution environment:
test_concurrent_futures

19 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_tcl test_tkinter test_ttk test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

Total duration: 38 min 13 sec

Click to see traceback logs
remote: Enumerating objects: 50, done.        
remote: Counting objects:   2% (1/50)        
remote: Counting objects:   4% (2/50)        
remote: Counting objects:   6% (3/50)        
remote: Counting objects:   8% (4/50)        
remote: Counting objects:  10% (5/50)        
remote: Counting objects:  12% (6/50)        
remote: Counting objects:  14% (7/50)        
remote: Counting objects:  16% (8/50)        
remote: Counting objects:  18% (9/50)        
remote: Counting objects:  20% (10/50)        
remote: Counting objects:  22% (11/50)        
remote: Counting objects:  24% (12/50)        
remote: Counting objects:  26% (13/50)        
remote: Counting objects:  28% (14/50)        
remote: Counting objects:  30% (15/50)        
remote: Counting objects:  32% (16/50)        
remote: Counting objects:  34% (17/50)        
remote: Counting objects:  36% (18/50)        
remote: Counting objects:  38% (19/50)        
remote: Counting objects:  40% (20/50)        
remote: Counting objects:  42% (21/50)        
remote: Counting objects:  44% (22/50)        
remote: Counting objects:  46% (23/50)        
remote: Counting objects:  48% (24/50)        
remote: Counting objects:  50% (25/50)        
remote: Counting objects:  52% (26/50)        
remote: Counting objects:  54% (27/50)        
remote: Counting objects:  56% (28/50)        
remote: Counting objects:  58% (29/50)        
remote: Counting objects:  60% (30/50)        
remote: Counting objects:  62% (31/50)        
remote: Counting objects:  64% (32/50)        
remote: Counting objects:  66% (33/50)        
remote: Counting objects:  68% (34/50)        
remote: Counting objects:  70% (35/50)        
remote: Counting objects:  72% (36/50)        
remote: Counting objects:  74% (37/50)        
remote: Counting objects:  76% (38/50)        
remote: Counting objects:  78% (39/50)        
remote: Counting objects:  80% (40/50)        
remote: Counting objects:  82% (41/50)        
remote: Counting objects:  84% (42/50)        
remote: Counting objects:  86% (43/50)        
remote: Counting objects:  88% (44/50)        
remote: Counting objects:  90% (45/50)        
remote: Counting objects:  92% (46/50)        
remote: Counting objects:  94% (47/50)        
remote: Counting objects:  96% (48/50)        
remote: Counting objects:  98% (49/50)        
remote: Counting objects: 100% (50/50)        
remote: Counting objects: 100% (50/50), done.        
remote: Compressing objects:   3% (1/26)        
remote: Compressing objects:   7% (2/26)        
remote: Compressing objects:  11% (3/26)        
remote: Compressing objects:  15% (4/26)        
remote: Compressing objects:  19% (5/26)        
remote: Compressing objects:  23% (6/26)        
remote: Compressing objects:  26% (7/26)        
remote: Compressing objects:  30% (8/26)        
remote: Compressing objects:  34% (9/26)        
remote: Compressing objects:  38% (10/26)        
remote: Compressing objects:  42% (11/26)        
remote: Compressing objects:  46% (12/26)        
remote: Compressing objects:  50% (13/26)        
remote: Compressing objects:  53% (14/26)        
remote: Compressing objects:  57% (15/26)        
remote: Compressing objects:  61% (16/26)        
remote: Compressing objects:  65% (17/26)        
remote: Compressing objects:  69% (18/26)        
remote: Compressing objects:  73% (19/26)        
remote: Compressing objects:  76% (20/26)        
remote: Compressing objects:  80% (21/26)        
remote: Compressing objects:  84% (22/26)        
remote: Compressing objects:  88% (23/26)        
remote: Compressing objects:  92% (24/26)        
remote: Compressing objects:  96% (25/26)        
remote: Compressing objects: 100% (26/26)        
remote: Compressing objects: 100% (26/26), done.        
remote: Total 26 (delta 24), reused 1 (delta 0), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '00e75a33728cdad7c10088acc36bc55b2f4a0efe'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 00e75a3372 gh-106084: Remove old PyObject call aliases (#106085)
Switched to and reset branch 'main'

./Modules/_testcapi/heaptype_relative.c: In function ‘make_sized_heaptypes’:
./Modules/_testcapi/heaptype_relative.c:62:28: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
   62 |                            (unsigned long long)data_ptr,
      |                            ^

make: *** [Makefile:2005: buildbottest] Error 3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

This comment was marked as off-topic.

Sign in to view
@encukou

This comment was marked as off-topic.

Sign in to view
@vstinner vstinner mentioned this pull request Nov 6, 2023
C API: Remove private C API functions (move them to the internal C API) #106320
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@tiran tiran Awaiting requested review from tiran
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @bedevere-bot @encukou @rhettinger
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.