GeezerVison is showing github.com — gh-106084: Remove _PyObject_CallMethod() function by vstinner · Pull Request #106159 · python/cpython
Conversation
vstinner
commented
Jun 27, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Remove the following private functions from the public C API:
- _Py_CheckFunctionResult()
- _PyObject_CallMethod()
- _PyObject_CallMethodId()
- _PyObject_CallMethodIdNoArgs()
- _PyObject_CallMethodIdObjArgs()
- _PyObject_CallMethodIdOneArg()
- _PyObject_MakeTpCall()
- _PyObject_VectorcallMethodId()
- _PyStack_AsDict()
Move these functions to the internal C API (pycore_call.h).
No longer export the following functions:
- _PyObject_Call()
- _PyObject_CallMethod()
- _PyObject_CallMethodId()
- _PyObject_CallMethodIdObjArgs()
- _PyObject_Call_Prepend()
- _PyObject_FastCallDictTstate()
- _PyStack_AsDict()
The following functions are still exported for stdlib shared extensions:
- _Py_CheckFunctionResult()
- _PyObject_MakeTpCall()
Mark the following internal functions as extern:
- _PyStack_UnpackDict()
- _PyStack_UnpackDict_Free()
- _PyStack_UnpackDict_FreeNoDecRef()
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Remove the following private functions from the public C API:
* _Py_CheckFunctionResult()
* _PyObject_CallMethod()
* _PyObject_CallMethodId()
* _PyObject_CallMethodIdNoArgs()
* _PyObject_CallMethodIdObjArgs()
* _PyObject_CallMethodIdOneArg()
* _PyObject_MakeTpCall()
* _PyObject_VectorcallMethodId()
* _PyStack_AsDict()
Move these functions to the internal C API (pycore_call.h).
No longer export the following functions:
* _PyObject_Call()
* _PyObject_CallMethod()
* _PyObject_CallMethodId()
* _PyObject_CallMethodIdObjArgs()
* _PyObject_Call_Prepend()
* _PyObject_FastCallDictTstate()
* _PyStack_AsDict()
The following functions are still exported for stdlib shared
extensions:
* _Py_CheckFunctionResult()
* _PyObject_MakeTpCall()
Mark the following internal functions as extern:
* _PyStack_UnpackDict()
* _PyStack_UnpackDict_Free()
* _PyStack_UnpackDict_FreeNoDecRef()
Reviewers
rhettinger
Awaiting requested review from rhettinger
rhettinger is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.