GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106168: PyTuple_SET_ITEM() now checks the index by vstinner · Pull Request #106164 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PyTuple_SET_ITEM() and PyList_SET_ITEM() now check the index argument
with an assertion if Python is built in debug mode or is built with
assertions.

  • list_extend() and _PyList_AppendTakeRef() now set the list size
    before calling PyList_SET_ITEM().
  • PyStructSequence_GetItem() and PyStructSequence_SetItem() now check
    the index argument: must be lesser than REAL_SIZE(op).
  • PyStructSequence_GET_ITEM() and PyStructSequence_SET_ITEM() are now
    aliases to PyStructSequence_GetItem() and
    PyStructSequence_SetItem().

📚 Documentation preview 📚: https://cpython-previews--106164.org.readthedocs.build/

  • Issue: C API: Check in PyTuple_SET_ITEM() and PyList_SET_ITEM() #106168

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner vstinner added the skip news label Jun 27, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jun 27, 2023
@vstinner vstinner added the skip issue label Jun 27, 2023
@vstinner
vstinner force-pushed the list_get_item_assert branch from 255edc3 to 9e5b27b Compare June 27, 2023 23:55
@vstinner vstinner changed the title PyList_GET_ITEM() now checks the index PyList_SET_ITEM() now checks the index Jun 27, 2023
@vstinner vstinner changed the title PyList_SET_ITEM() now checks the index gh-106168: PyTuple_SET_ITEM() now checks the index Jun 28, 2023
@vstinner vstinner removed skip issue skip news labels Jun 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2023
C API: Check in PyTuple_SET_ITEM() and PyList_SET_ITEM() #106168
Closed
@vstinner
pythongh-106168: PyTuple_SET_ITEM() now checks the index
fb5b51b
PyTuple_SET_ITEM() and PyList_SET_ITEM() now check the index argument
with an assertion if Python is built in debug mode or is built with
assertions.

* list_extend() and _PyList_AppendTakeRef() now set the list size
  before calling PyList_SET_ITEM().
* PyStructSequence_GetItem() and PyStructSequence_SetItem() now check
  the index argument: must be lesser than REAL_SIZE(op).
* PyStructSequence_GET_ITEM() and PyStructSequence_SET_ITEM() are now
  aliases to PyStructSequence_GetItem() and
  PyStructSequence_SetItem().
@vstinner
vstinner force-pushed the list_get_item_assert branch from 9e5b27b to fb5b51b Compare June 28, 2023 01:05
@vstinner
Update the doc
9eb147d
@vstinner
vstinner merged commit 3f8483c into python:main Jun 28, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 28, 2023
@vstinner
vstinner deleted the list_get_item_assert branch June 28, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.