GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106162: fix test_array modifies warning filter by methane · Pull Request #106181 · python/cpython

Conversation

@methane

@methane methane commented Jun 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_array modifies warnings.filter #106162

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
pythongh-106162: fix test_array modifies farning filter
6640bce
@methane methane added the skip news label Jun 28, 2023
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 28, 2023
test_array modifies warnings.filter #106162
Closed
@methane

methane commented Jun 28, 2023

Copy link
Copy Markdown
Member Author 
inada-n@PC-4524 ~/w/p/cpython (fix-test-array-warning-filter)> ./python.exe -m test test_array --fail-env-changed -m test.test_array.ArrayReconstructorTest.test_error
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 1.93 Run tests sequentially
0:00:00 load avg: 1.93 [1/1] test_array

== Tests result: SUCCESS ==

1 test OK.

Total duration: 36 ms
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sunmy2019
sunmy2019 approved these changes Jun 28, 2023
View reviewed changes

@sunmy2019 sunmy2019 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, clever. I have been always wondering how to apply context manager to a test case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
methane merged commit a3dd8cc into python:main Jun 28, 2023
@methane
methane deleted the fix-test-array-warning-filter branch June 28, 2023 07:50
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 28, 2023
@AlexWaygood AlexWaygood changed the title gh-106162: fix test_array modifies farning filter gh-106162: fix test_array modifies warning filter Jun 28, 2023
@methane methane mentioned this pull request Jul 4, 2023
gh-106162: array: suppress warning in test_array #106404
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunmy2019 sunmy2019 sunmy2019 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@methane @sunmy2019 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.