GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106309: Deprecate typing.no_type_check_decorator by AlexWaygood · Pull Request #106312 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jul 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #106309. Closes python/typing#1425.

  • Issue: Deprecate typing.no_type_check_decorator #106309

📚 Documentation preview 📚: https://cpython-previews--106312.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-106309: Deprecate typing.no_type_check_decorator
6c494a4
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners July 1, 2023 15:56
@bedevere-bot bedevere-bot added the awaiting core review label Jul 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 1, 2023
Deprecate typing.no_type_check_decorator #106309
Closed
@AlexWaygood
formatting nit
53dbad0
@AlexWaygood AlexWaygood added type-feature A feature request or enhancement topic-typing 3.13 only security fixes labels Jul 1, 2023
hauntsaninja
hauntsaninja approved these changes Jul 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 1, 2023
@AlexWaygood

AlexWaygood commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

(Going to hold off merging this for at least a few days, in case anybody has any objections)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Jul 1, 2023

Copy link
Copy Markdown
Member

Could you post to typing-sig about this and wait for at least a week? I don't think a lot of community members follow every typing PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Jul 1, 2023

Copy link
Copy Markdown
Member Author

Could you post to typing-sig about this and wait for at least a week? I don't think a lot of community members follow every typing PR.

Yes, sounds like a plan
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Jul 1, 2023
View reviewed changes
@AlexWaygood
ASCII-art Sphinx tables
44ec437
@AlexWaygood
AlexWaygood merged commit 32718f9 into python:main Jul 13, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 13, 2023
@AlexWaygood
AlexWaygood deleted the deprecate-no-type-check-decorator branch July 13, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@hauntsaninja hauntsaninja hauntsaninja approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.13 only security fixes topic-typing type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Cross-post]: Let's deprecate typing.no_type_check_decorator Deprecate typing.no_type_check_decorator

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AlexWaygood @JelleZijlstra @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.