GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-102541: Fix Helper.help("mod") for non-existent mod (GH-105934) by miss-islington · Pull Request #106323 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None.

(cherry picked from commit 0530f4f)

Co-authored-by: Kirill Podoprigora [email protected]
Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: help CLI shows a traceback when import failed #102541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Eclips4 @terryjreedy @miss-islington
pythongh-102541: Fix Helper.help("mod") for non-existent mod (pythonG…
6b55c26
…H-105934)

If the output arg to Helper() is a stream rather than the default None, which means 'page to stdout', the ImportError from pydoc.resolve is currently not caught in pydoc.doc. The same error is caught when output is None.
---------

(cherry picked from commit 0530f4f)

Co-authored-by: Kirill Podoprigora <[email protected]>
Co-authored-by: Terry Jan Reedy <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Jul 1, 2023
This was referenced Jul 1, 2023
help CLI shows a traceback when import failed #102541
Closed
gh-102541: Fix Helper.help("mod") for non-existent mod #105934
Merged
@terryjreedy
terryjreedy enabled auto-merge (squash) July 1, 2023 22:47
@terryjreedy
terryjreedy merged commit 9e33586 into python:3.11 Jul 1, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Jul 1, 2023
@miss-islington
miss-islington deleted the backport-0530f4f-3.11 branch July 1, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @bedevere-bot @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.