GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106078: Move `context template` to decimal module global state by CharlieZhao95 · Pull Request #106346 · python/cpython

Conversation

@CharlieZhao95

@CharlieZhao95 CharlieZhao95 commented Jul 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Move following context template objectes to decimal module global state.

  • default_context_template
  • basic_context_template
  • extended_context_template
  • Issue: Isolate the _decimal extension module #106078

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CharlieZhao95 added 2 commits July 3, 2023 09:37
@CharlieZhao95
Move context templates to global state
26624f1
@CharlieZhao95
update globals-to-fix
a1a4ddb
@CharlieZhao95
CharlieZhao95 requested a review from rhettinger as a code owner July 3, 2023 01:49
@bedevere-bot bedevere-bot added the awaiting review label Jul 3, 2023
@CharlieZhao95 CharlieZhao95 changed the title gh106078: Move context template to decimal module global state gh-106078: Move context template to decimal module global state Jul 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 3, 2023
Isolate the _decimal extension module #106078
Closed
14 tasks done
@CharlieZhao95

CharlieZhao95 commented Jul 3, 2023

Copy link
Copy Markdown
Contributor Author

cc: @kumaraditya303 @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Jul 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 3, 2023
@erlend-aasland erlend-aasland added awaiting review skip news and removed awaiting merge labels Jul 3, 2023
@rhettinger
rhettinger removed their request for review July 3, 2023 16:34
kumaraditya303
kumaraditya303 approved these changes Jul 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 3, 2023
@kumaraditya303
kumaraditya303 merged commit bf06c68 into python:main Jul 3, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@CharlieZhao95 @erlend-aasland @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.