GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-106330: Fix matching of empty path in `pathlib.PurePath.match()` (GH-106331) by barneygale · Pull Request #106372 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jul 3, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We match paths using the _lines attribute, which is derived from the path's string representation. The bug arises because an empty path's string representation is '.' (not ''), which is matched by the '*' wildcard. (cherry picked from commit b4efdf8)

  • Issue: pathlib.PurePath.match() can incorrectly match empty path #106330

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@barneygale
[3.12] pythonGH-106330: Fix matching of empty path in `pathlib.PurePa…
e320740
…th.match()` (pythonGH-106331)

We match paths using the `_lines` attribute, which is derived from the
path's string representation. The bug arises because an empty path's string
representation is `'.'` (not `''`), which is matched by the `'*'` wildcard.
(cherry picked from commit b4efdf8)

Co-authored-by: Barney Gale <[email protected]>
@barneygale barneygale added the topic-pathlib label Jul 3, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 3, 2023
This was referenced Jul 3, 2023
pathlib.PurePath.match() can incorrectly match empty path #106330
Closed
GH-106330: Fix matching of empty path in pathlib.PurePath.match() #106331
Merged
@barneygale
barneygale enabled auto-merge (squash) July 3, 2023 20:32
@barneygale
barneygale disabled auto-merge July 3, 2023 20:56
@barneygale
Backport handling of * segments from main.
799044d
@barneygale
barneygale merged commit d5ed72b into python:3.12 Jul 4, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.