GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106078: Move static variables initialized once to decimal module global state by CharlieZhao95 · Pull Request #106475 · python/cpython

Conversation

@CharlieZhao95

@CharlieZhao95 CharlieZhao95 commented Jul 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Move round_map to decimal module global state.

  • Issue: Isolate the _decimal extension module #106078

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CharlieZhao95
Move round_map to decimal module global state
66f1046
@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2023
Isolate the _decimal extension module #106078
Closed
14 tasks done
CharlieZhao95 added 2 commits July 10, 2023 09:29
@CharlieZhao95
Merge remote-tracking branch 'upstream/main' into decimal/round_map
25427eb
@CharlieZhao95
Move Rational and SignalTuple
6b64f7b
@CharlieZhao95 CharlieZhao95 changed the title gh-106078: Move round_map to decimal module global state gh-106078: Move static variables initialized once to decimal module global state Jul 10, 2023
@CharlieZhao95
update globals-to-fix
a40f73b
@CharlieZhao95
CharlieZhao95 marked this pull request as ready for review July 10, 2023 06:18
@CharlieZhao95
CharlieZhao95 requested a review from rhettinger as a code owner July 10, 2023 06:18
@bedevere-bot bedevere-bot added the awaiting review label Jul 10, 2023
@CharlieZhao95

CharlieZhao95 commented Jul 10, 2023

Copy link
Copy Markdown
Contributor Author

cc: @kumaraditya303 @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger removed their request for review July 10, 2023 06:47
kumaraditya303
kumaraditya303 approved these changes Jul 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 10, 2023
@kumaraditya303 kumaraditya303 added the skip news label Jul 10, 2023
@kumaraditya303
kumaraditya303 merged commit 9384665 into python:main Jul 10, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CharlieZhao95 @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.