GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104584: Handle EXTENDED_ARG in superblock creation by gvanrossum · Pull Request #106489 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jul 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also fixed and cleaned up test_capi.test_misc.TestUops, and added a new test proving that EXTENDED_ARG works.

  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gvanrossum
gvanrossum requested a review from markshannon July 6, 2023 19:48
@bedevere-bot bedevere-bot added the awaiting core review label Jul 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2023
Pluggable optimizer API #104584
Closed
@gvanrossum gvanrossum added the skip news label Jul 6, 2023
@gvanrossum

gvanrossum commented Jul 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Tests are failing. I'll regroup and see if my EXTENDED_ARG handling is at fault or if it was pre-existing, and then proceed from there. For now, this is another Draft PR, and I'll isolate my test cleanups in a new PR.


UPDATE: Fixed by gh-106492, rebased, undrafted.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum
gvanrossum marked this pull request as draft July 6, 2023 20:42
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 6, 2023
@gvanrossum

gvanrossum commented Jul 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I get the same failure with just Fix and clean up uops and executor API. That makes me think the root problem is pre-existing (since that commit has no C code). I'll see if the address sanitizer will help me debug this.


UPDATE: Yeah, the UOpOptimizer type was missing a tp_dealloc handler. Nasty. Fixing that in gh-106492. Once that's merged I'll rebase and undraft this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum gvanrossum mentioned this pull request Jul 6, 2023
gh-104584: Clean up and fix uops tests and fix crash #106492
Merged
gvanrossum added 2 commits July 6, 2023 15:47
@gvanrossum
Support EXTENDED_ARG
8062a6e
@gvanrossum
Add a test to verify EXTENDED_ARG handling
f11ebff
@gvanrossum
gvanrossum force-pushed the uops-extended-arg branch from ba006c1 to f11ebff Compare July 6, 2023 22:50
@gvanrossum
gvanrossum marked this pull request as ready for review July 6, 2023 22:51
@bedevere-bot bedevere-bot added the awaiting core review label Jul 6, 2023
@gvanrossum
gvanrossum merged commit e1d45b8 into python:main Jul 6, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 6, 2023
@gvanrossum
gvanrossum deleted the uops-extended-arg branch July 6, 2023 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.