GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104584: Allow unspecialized instructions in superblocks by gvanrossum · Pull Request #106497 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jul 6, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is done by not searching for forbidden words inside #if ENABLE_SPECIALIZATION. (And making that flag false when the Tier 2 uops are being compiled.)

@markshannon, I know this is controversial, but while we are incrementally developing superblock generation, I find it helpful if there are as many superblocks as possible, and those are as long as possible. Allowing unspecialized instructions helps towards this goal (and is quicker than inventing new specializations). I'm making it its own PR so hopefully it will be easy to roll back in the future. (In fact, all you'd have to do is change the one call to variable_used_unspecialized in generate_cases.py back to variable_used, and regenerate.)

  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
gvanrossum added 2 commits July 6, 2023 16:00
@gvanrossum
No forbidden words in #if ENABLE_SPECIALIZATION
f936d17
This adds a whole bunch of unspecialized opcodes to superblocks.
While we may not want that eventually, for now this helps finding bugs.
@gvanrossum
Add test for unspecialized uop UNPACK_SEQUENCE
7b1a96b
@gvanrossum
gvanrossum requested a review from markshannon July 6, 2023 23:18
@bedevere-bot bedevere-bot added the awaiting core review label Jul 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2023
Pluggable optimizer API #104584
Closed
@markshannon

markshannon commented Jul 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I'm hoping that our specialization will become good enough that it will be become largely irrelevant whether we include unspecialized instructions or not.

If it helps testing, then let's add them. As you say, we can also remove them later if they are a problem.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum added 2 commits July 7, 2023 09:36
@gvanrossum
Add comment explaining how to undo this
b026112
@gvanrossum
Merge remote-tracking branch 'origin/main' into unspecialized-uops
e2758f2
@gvanrossum gvanrossum added the skip news label Jul 7, 2023
@gvanrossum
gvanrossum enabled auto-merge (squash) July 7, 2023 16:47
@gvanrossum
Regen cases
c30eee9
@gvanrossum
gvanrossum merged commit b3648f0 into python:main Jul 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 7, 2023
@gvanrossum
gvanrossum deleted the unspecialized-uops branch July 7, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.