GeezerVison

I tried long and hard to see if there was a sane way of annotating the output field of the Block class. In the end I concluded that, from a typing perspective, the current code is somewhat insane, so there's no sane way of doing it without substantially refactoring the code first 🙃 For now, I propose that we annotate it with Any and leave it for another day.

The issue is that output usually has type str | None, as stated by the docstring here:

But whenever self.block is referenced from inside the DSLParser class, it's of type list[str] (I'm pretty confident self.block is an instance of Block):

This is because DSLParser.parse() sets block.output to a list at the beginning of the function, and then sets it back to a string at the end of the function:

Needless to say, this makes mypy furious if you give Block.output a type that isn't Any 🙃

• Issue: Add type annotations to clinic.py #104050