GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105927: PyWeakref_GetRef() returns 1 on success by vstinner · Pull Request #106561 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 9, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PyWeakref_GetRef() now returns 1 on success, and return 0 if the reference is dead.

  • Issue: C API: Add PyWeakref_GetRef() function #105927

📚 Documentation preview 📚: https://cpython-previews--106561.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-105927: PyWeakref_GetRef() returns 1 on success
3de3579 
PyWeakref_GetRef() now returns 1 on success, and return 0 if the
reference is dead.
@vstinner vstinner added the skip news label Jul 9, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 9, 2023
C API: Add PyWeakref_GetRef() function #105927
Closed
@vstinner

vstinner commented Jul 9, 2023

Copy link
Copy Markdown
Member Author

PR to update the newly added C API to respect the new C API guidelines: https://devguide.python.org/developer-workflow/c-api/index.html

APIs with lesser and greater results must return 0 for the lesser result, and 1 for the greater result. Consider a lookup function with a three-way return: (...)

cc @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jul 9, 2023
gh-105927: Add PyWeakref_GetRef() function #105932
Merged
@vstinner

vstinner commented Jul 9, 2023

Copy link
Copy Markdown
Member Author

cc @encukou
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jul 9, 2023
View reviewed changes
Comment thread Objects/weakrefobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 9, 2023
@vstinner @serhiy-storchaka
Update Objects/weakrefobject.c
727a655 
Co-authored-by: Serhiy Storchaka <[email protected]>
@vstinner
vstinner enabled auto-merge (squash) July 9, 2023 15:29
@vstinner

vstinner commented Jul 9, 2023

Copy link
Copy Markdown
Member Author

Thanks for the review @serhiy-storchaka.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit ee46cb6 into python:main Jul 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 9, 2023
@vstinner
vstinner deleted the weakref_getref_success branch July 9, 2023 16:10
@vstinner

vstinner commented Jul 9, 2023

Copy link
Copy Markdown
Member Author

I updated pythoncapi-compat: python/pythoncapi-compat@d000b55
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.