GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-61215: threadingmock: Remove unused branch for `timeout` by mariocj89 · Pull Request #106591 · python/cpython

Conversation

@mariocj89

@mariocj89 mariocj89 commented Jul 10, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Issue: #61215

  • Issue: Allow waiting on a mock #61215

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mariocj89
threadingmock: Remove unused branch for timeout
0951508 
This is no longer needed as the mock does not hold a "timeout"
parameter, the timeout is stored in `_mock_wait_timeout`.
@mariocj89
mariocj89 requested a review from cjw296 as a code owner July 10, 2023 13:03
@bedevere-bot bedevere-bot added the awaiting review label Jul 10, 2023
@mariocj89 mariocj89 changed the title threadingmock: Remove unused branch for timeout GH-61215: threadingmock: Remove unused branch for timeout Jul 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 4, 2023
Allow waiting on a mock #61215
Closed
@mariocj89 mariocj89 mentioned this pull request Jul 10, 2023
gh-61215: New mock to wait for multi-threaded events to happen #16094
Merged
cjw296
cjw296 approved these changes Jul 10, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 10, 2023
@cjw296
cjw296 enabled auto-merge (squash) July 10, 2023 13:35
@cjw296 cjw296 added the skip news label Jul 10, 2023
@cjw296
cjw296 merged commit 3e23fa7 into python:main Jul 10, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 cjw296 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mariocj89 @cjw296 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.