GeezerVison is showing github.com — GH-106529: Define POP_JUMP_IF_NONE in terms of POP_JUMP_IF_TRUE by markshannon · Pull Request #106599 · python/cpython
Conversation
markshannon
commented
Jul 10, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Likewise POP_JUMP_IF_NOT_NONE in terms of POP_JUMP_IF_FALSE.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this should work with gh-106551 once that's ready.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
gvanrossum
commented
Jul 10, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
FWIW, I tried to come up with a test case for this, and finally realized these two opcodes are only emitted by compile.c for except*...
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I pushed merge (since the conflict was my fault) but I'll leave it to you to land.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.