GeezerVison is showing github.com — gh-106521: Remove _PyObject_LookupAttr() function by serhiy-storchaka · Pull Request #106642 · python/cpython
Conversation
It is an automatic replace in C files and Parser/asdl_c.py.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka
requested review from
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
ericsnowcurrently,
erlend-aasland,
gvanrossum,
iritkatriel,
isidentical,
kumaraditya303,
markshannon,
methane,
ncoghlan,
pganssle,
rhettinger,
warsaw and
willingc
as code owners
July 11, 2023 19:34
serhiy-storchaka
removed request for
abalkin,
ericsnowcurrently,
erlend-aasland,
gvanrossum,
iritkatriel,
isidentical,
kumaraditya303,
markshannon,
pganssle,
rhettinger and
willingc
July 11, 2023 19:34
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
You may change the change title to "Remove _PyObject_LookupAttr() function". In practice (in terms of C API), this change removes the function, since the previous change added a new function. I'm fine with removing private functions, but it seems like @encukou started to have concerns about such removals in Python 3.13 C API: see #106320
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
serhiy-storchaka reacted with thumbs up emoji
serhiy-storchaka
changed the title
gh-106521: Replace _PyObject_LookupAttr with PyObject_GetOptionalAttr in code
gh-106521: Remove _PyObject_LookupAttr() function
Jul 12, 2023
Reviewers
carljm
carljm approved these changes
vstinner
vstinner approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|