GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106529: Implement JUMP_FORWARD in uops (with test) by gvanrossum · Pull Request #106651 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jul 11, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a very simple one. Figuring out how to test it took longer than writing the implementation.

Note that this may generate two SAVE_IP uops in a row. As a matter of principle, I don't do anything to avoid that -- removing unneeded SAVE_IP uops is the optimizer's job.

I'll probably just merge once the tests pass.

  • Issue: Branching design for Tier 2 (uops) interpreter #106529

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@gvanrossum
Implement JUMP_FORWARD in uops (with test)
571b452
@gvanrossum gvanrossum added the skip news label Jul 11, 2023
@gvanrossum
gvanrossum requested a review from markshannon July 11, 2023 20:48
@bedevere-bot bedevere-bot added the awaiting core review label Jul 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 11, 2023
Branching design for Tier 2 (uops) interpreter #106529
Closed
7 of 11 tasks
@gvanrossum
gvanrossum merged commit da86db5 into python:main Jul 11, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 11, 2023
@gvanrossum
gvanrossum deleted the jump-forward branch July 11, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.