GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105481: move Python/opcode_metadata.h to Include/internal/pycore_opcode_metadata.h by iritkatriel · Pull Request #106673 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We want to make this data available through _opcode.py, so it needs to be in Include.

  • Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-105481: move Python/opcode_metadata.h to Include/internal/py…
9272e67 
…core_opcode_metadata.h
@iritkatriel
iritkatriel requested a review from markshannon as a code owner July 12, 2023 09:14
@bedevere-bot bedevere-bot added the awaiting core review label Jul 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 12, 2023
Generate opcode metadata from bytecodes.c instead of opcode.py #105481
Closed
@markshannon markshannon added the skip news label Jul 12, 2023
markshannon
markshannon approved these changes Jul 12, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 12, 2023
@iritkatriel
iritkatriel merged commit 2ca008e into python:main Jul 12, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 12, 2023
@iritkatriel
iritkatriel deleted the move_metadata branch July 12, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.