GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104909: Break LOAD_GLOBAL specializations in micro-ops. by markshannon · Pull Request #106677 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Split opcodes into micro-ops #104909

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 4 commits June 2, 2023 00:56
@markshannon
Break LOAD_GLOBAL specializations in micro-ops. WIP.
c57e981
@markshannon
Merge branch 'main' into split-load-global
4c76057
@markshannon
Generate files
87f27cd
@markshannon
Add news
bd4a57e
@bedevere-bot bedevere-bot added the awaiting core review label Jul 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 13, 2023
Split opcodes into micro-ops #104909
Closed
markshannon added 3 commits July 12, 2023 10:52
@markshannon
Merge branch 'main' into split-load-global
dae3f7d
@markshannon
Fix markup
1bbc515
@markshannon
Merge branch 'main' into split-load-global
b33d1e1
iritkatriel
iritkatriel reviewed Jul 12, 2023
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jul 12, 2023
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
Address review comments
2e8712d
@markshannon

markshannon commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

No performance impact https://github.com/faster-cpython/benchmarking-public/tree/main/results/bm-20230712-3.13.0a0-1bbc515
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Jul 12, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 12, 2023
@markshannon
markshannon merged commit b03755a into python:main Jul 12, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 12, 2023
@markshannon
markshannon deleted the split-load-global branch July 12, 2023 13:35
@iritkatriel iritkatriel mentioned this pull request Jul 13, 2023
gh-106529: Split FOR_ITER_{LIST,TUPLE} into uops #106696
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.