GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105481: expose opcode metadata via the _opcode module by iritkatriel · Pull Request #106688 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-105481: expose opcode metadata via the _opcode module
d65881b
@bedevere-bot bedevere-bot added the awaiting core review label Jul 12, 2023
@iritkatriel
iritkatriel requested a review from gvanrossum July 12, 2023 18:47
@bedevere-bot bedevere-bot mentioned this pull request Jul 12, 2023
Generate opcode metadata from bytecodes.c instead of opcode.py #105481
Closed
@iritkatriel
compile.c needs metadata, flowgraph doesn't
ba367b2
@iritkatriel
iritkatriel requested a review from markshannon as a code owner July 12, 2023 20:35
@iritkatriel
iritkatriel marked this pull request as draft July 12, 2023 20:40
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 12, 2023
@iritkatriel

iritkatriel commented Jul 12, 2023

Copy link
Copy Markdown
Member Author

There's a problem here with the definition of the metadata table. I'll try to sort it out tomorrow.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 3 commits July 13, 2023 11:36
@iritkatriel
add PyUnstable_OpcodeMetadata so Modules/ can get metadata
b354891
@iritkatriel
Merge branch 'main' into expose_metadata
8a71700
@iritkatriel
add news
8f15de8
gvanrossum
gvanrossum approved these changes Jul 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added the awaiting merge label Jul 13, 2023
iritkatriel added 2 commits July 14, 2023 10:10
@iritkatriel
don't expose opcode_metadata
63fabee
@iritkatriel
Merge remote-tracking branch 'upstream/main' into expose_metadata
3486a67
iritkatriel
iritkatriel commented Jul 14, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2023-07-13-16-04-15.gh-issue-105481.pYSwMj.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel and others added 3 commits July 14, 2023 12:41
@iritkatriel
typos
517f7b1
@iritkatriel
remove unused #include
ca88100
@iritkatriel
revert unintended change
c2f33ce
@iritkatriel
iritkatriel marked this pull request as ready for review July 14, 2023 14:39
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Jul 14, 2023
gvanrossum
gvanrossum approved these changes Jul 14, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something worries me about the amount of repetition for each flag. But the alternative (exposing the flags as an int, and the constants) seems worse. So go for it!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 14, 2023
@iritkatriel

iritkatriel commented Jul 14, 2023

Copy link
Copy Markdown
Member Author

Yes, I didn't want to expose the bitmap implementation.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 6a70edf into python:main Jul 14, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 14, 2023
@iritkatriel
iritkatriel deleted the expose_metadata branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.