GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102799: replace internal sys.exc_info() call by sys.exception() by iritkatriel · Pull Request #106746 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is another call, but that one is external facing so we need to be more careful about it. But we can get this one out of the way easily.

  • Issue: some usages of sys.exc_info can be replaced by more modern code #102799

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-102799: replace internal sys.exc_info() call by sys.exception()
f3c1848
@iritkatriel
iritkatriel requested a review from vsajip as a code owner July 14, 2023 15:25
@bedevere-bot bedevere-bot added the awaiting core review label Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request May 1, 2023
some usages of sys.exc_info can be replaced by more modern code #102799
Closed
@iritkatriel iritkatriel added skip news stdlib Standard Library Python modules in the Lib/ directory labels Jul 14, 2023
vsajip
vsajip approved these changes Jul 14, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 14, 2023
@iritkatriel
iritkatriel merged commit fb32f35 into python:main Jul 14, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 14, 2023
@iritkatriel
iritkatriel deleted the exc_info-logging branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news stdlib Standard Library Python modules in the Lib/ directory

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @vsajip @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.