GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106529: Fix subtle Tier 2 edge case with list iterator by gvanrossum · Pull Request #106756 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jul 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The Tier 2 opcode _IS_ITER_EXHAUSTED_LIST (and _TUPLE)
didn't set it->it_seq to NULL, causing a subtle bug
that resulted in test_exhausted_iterator in list_tests.py
to fail when running all tests with -Xuops.

The bug was introduced in gh-106696.

Added this as an explicit test.

Also fixed the dependencies for ceval.o -- it depends on executor_cases.c.h.

  • Issue: Branching design for Tier 2 (uops) interpreter #106529

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum added 3 commits July 14, 2023 13:23
@gvanrossum
Add failing test
99c37b6 
https://github.com/python/cpython/actions/runs/5557504750/jobs/10151384516?pr=106707
@gvanrossum
Fix deps for ceval.o
ad9e5a3
@gvanrossum
Fix subtle Tier 2 edge case with list iterator
4a785bf 
The Tier 2 opcode _IS_ITER_EXHAUSTED_LIST (and _TUPLE)
didn't set `it->it_seq` to NULL, causing a subtle bug
that resulted in test_exhausted_iterator in list_tests.py
to fail.
@bedevere-bot bedevere-bot added the awaiting core review label Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Branching design for Tier 2 (uops) interpreter #106529
Closed
7 of 11 tasks
@gvanrossum gvanrossum mentioned this pull request Jul 14, 2023
gh-106581: Add 10 new opcodes by allowing assert(kwnames == NULL) #106707
Merged
@gvanrossum gvanrossum added the skip news label Jul 15, 2023
@gvanrossum
gvanrossum merged commit 0db85ee into python:main Jul 15, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 15, 2023
@gvanrossum
gvanrossum deleted the fix-list-iter branch July 15, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.