GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104050: Argument Clinic: Annotate Clinic.parse() by erlend-aasland · Pull Request #106760 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jul 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add type annotations to clinic.py #104050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104050: Argument Clinic: Annotate Clinic.parse()
dd434fb 
As a consequence, also add a generic Parser ABC
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner July 14, 2023 22:13
@erlend-aasland erlend-aasland added the skip news label Jul 14, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Add type annotations to clinic.py #104050
Closed
AlexWaygood
AlexWaygood reviewed Jul 15, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits July 15, 2023 21:18
@erlend-aasland
Pull in main
535ef11
@erlend-aasland
Make it protocol!
edcd854
erlend-aasland
erlend-aasland commented Jul 15, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Readability
57ed0a1
@erlend-aasland
erlend-aasland requested a review from AlexWaygood July 16, 2023 18:59
AlexWaygood
AlexWaygood approved these changes Jul 16, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nitpicks, but nothing blocking!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 16, 2023
erlend-aasland and others added 2 commits July 17, 2023 01:25
@erlend-aasland @AlexWaygood
Apply suggestions from code review
2c9075d 
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland @AlexWaygood
Update Tools/clinic/clinic.py
96dae0c 
Co-authored-by: Alex Waygood <[email protected]>
@erlend-aasland
erlend-aasland enabled auto-merge (squash) July 16, 2023 23:27
@erlend-aasland
erlend-aasland merged commit 383dcbe into python:main Jul 17, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 17, 2023
@erlend-aasland
erlend-aasland deleted the clinic/annotate-clinic-parse branch July 17, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.