GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106078: Prepare to isolate decimal module by CharlieZhao95 · Pull Request #106880 · python/cpython

Conversation

@CharlieZhao95

@CharlieZhao95 CharlieZhao95 commented Jul 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The DecCondMap contains a potentially global variable(ex, a subclass of DecimalException). We should also move signal_map and cond_map to module state.

  • Move signal_map and cond_map to global state
  • Initialize array of DecCondMap using heap memory (Prepare to isolate module)
  • Issue: Isolate the _decimal extension module #106078

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CharlieZhao95 added 2 commits July 18, 2023 11:22
@CharlieZhao95
move signal_map to global_state
00bf785
@CharlieZhao95
move cond_map to global_state
0689946
@bedevere-bot bedevere-bot mentioned this pull request Jul 19, 2023
Isolate the _decimal extension module #106078
Closed
14 tasks done
@CharlieZhao95
Update ignored.tsv
01cbf7a
@CharlieZhao95

CharlieZhao95 commented Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

cc: @erlend-aasland @kumaraditya303
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CharlieZhao95
CharlieZhao95 marked this pull request as ready for review July 19, 2023 07:04
@CharlieZhao95
CharlieZhao95 requested a review from rhettinger as a code owner July 19, 2023 07:04
@bedevere-bot bedevere-bot added the awaiting review label Jul 19, 2023
@rhettinger
rhettinger removed their request for review July 19, 2023 19:54
kumaraditya303
kumaraditya303 approved these changes Jul 20, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 20, 2023
@kumaraditya303

kumaraditya303 commented Jul 20, 2023

Copy link
Copy Markdown
Contributor 
root@codespaces-62bef3 /w/cpython (decimal/move_condmap)# ./python -m test -R 3:3 test_decimal
0:00:00 load avg: 37.18 Run tests sequentially
0:00:00 load avg: 37.18 [1/1] test_decimal
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

1 test OK.

Total duration: 26.0 sec
Tests result: SUCCESS
CharlieZhao95 and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303
kumaraditya303 disabled auto-merge July 20, 2023 09:23
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) July 20, 2023 09:23
@kumaraditya303 kumaraditya303 added the skip news label Jul 20, 2023
@kumaraditya303
kumaraditya303 merged commit a1620dd into python:main Jul 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@CharlieZhao95 @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.