GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104584: Miscellaneous fixes for `-Xuops` by brandtbucher · Pull Request #106908 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jul 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes all of the tests that fail with the optimizer on.

By file:

  • Lib/dis.py: Teach dis how to parse bytecode containing ENTER_EXECUTOR or INSTRUMENTED_* instructions (by parsing the original code string instead and swapping in the adaptive opcodes at the last minute).
    • Fixes test_dis.
  • Lib/test/test_capi/test_misc.py and Lib/test_dis.py: Modify the tests' expected behavior when an optimizer is active.
    • Fixes test_dis and test_capi.
  • Python/bytecodes.c, Python/generated_cases.c.h, and Python/optimizer.c: Don't run the optimizer on instrumented back-edges.
    • Fixes test_monitoring, test_sys_settrace, and test_trace.
  • Python/executor_cases.c.h and Tools/cases_generator/generate_cases.py: Check the eval breaker when interpreting uops to avoid infinite closed loops.
    • Fixes test_gdb and test_os.
  • Python/pylifecycle.c: Fix refleak when installing optimizer.
    • Fixes test_embed.
  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 5 commits July 18, 2023 16:14
@brandtbucher
Fix failing C-API test
4c2385b
@brandtbucher
Fix refleak
630bfc8
@brandtbucher
Fix dis
2312b53
@brandtbucher
Fix bad line events
70d28d8
@brandtbucher
Don't hang in closed loops
db15329
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 20, 2023
@brandtbucher
brandtbucher requested review from gvanrossum and markshannon July 20, 2023 06:51
@brandtbucher brandtbucher self-assigned this Jul 20, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Pluggable optimizer API #104584
Closed
@brandtbucher
blurb add
a23c39e
gvanrossum
gvanrossum approved these changes Jul 20, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!!!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 20, 2023
@brandtbucher brandtbucher removed the skip news label Jul 20, 2023
@brandtbucher
brandtbucher enabled auto-merge (squash) July 20, 2023 16:13
@brandtbucher
brandtbucher merged commit 214a25d into python:main Jul 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brandtbucher @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.