GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105481: do not auto-generate pycore_intrinsics.h by iritkatriel · Pull Request #106913 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

pycore_intrinsics.h is currently auto-generated by the build script, which adds complications to the build process but doesn't really buy us anything. This PR defines them in C and exposes through a method in the _opcode module. There are two places where the list of intrinsics is defined before and after this change.

  • Issue: Generate opcode metadata from bytecodes.c instead of opcode.py #105481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iritkatriel
do not generate Include/internal/pycore_intrinsics.h
74fc92e
@bedevere-bot bedevere-bot added the awaiting core review label Jul 20, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 14, 2023
Generate opcode metadata from bytecodes.c instead of opcode.py #105481
Closed
@iritkatriel
iritkatriel requested a review from gvanrossum July 20, 2023 13:51
@iritkatriel
undef INTRINSIC_FUNC_ENTRY
ef8c521
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
@bedevere-bot

bedevere-bot commented Jul 20, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ef8c521 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jul 20, 2023
@iritkatriel iritkatriel added the skip news label Jul 20, 2023
gvanrossum
gvanrossum approved these changes Jul 20, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the process for adding a new intrinsic is now just to add a line to the appropriate table and add a define to pycore_intrinsics.h and update the MAX define there? That's not too tedious.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 20, 2023
@iritkatriel

iritkatriel commented Jul 20, 2023

Copy link
Copy Markdown
Member Author

Some of the refleaks failures look like this:

======================================================================
FAIL: test_extended_arg (test.test_capi.test_misc.TestUops.test_extended_arg)
Check EXTENDED_ARG handling in superblock creation
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/buildbot/buildarea/pull_request.cstratak-RHEL7-x86_64.refleak/build/Lib/test/test_capi/test_misc.py", line 2491, in test_extended_arg
    self.assertIsNone(ex)
AssertionError: <uop_executor object at 0x1c24a50> is not None
----------------------------------------------------------------------
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 9c81fc2 into python:main Jul 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 20, 2023
@iritkatriel
iritkatriel deleted the intrinsics branch July 25, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.