GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106916: Add missing error check by Eclips4 · Pull Request #106921 · python/cpython

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jul 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Forgot to add error check? #106916

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Eclips4
pythongh-106916: Add missing error check
618f708
@Eclips4
Eclips4 requested review from iritkatriel and markshannon as code owners July 20, 2023 18:00
@bedevere-bot bedevere-bot mentioned this pull request Jul 20, 2023
Forgot to add error check? #106916
Closed
@bedevere-bot bedevere-bot added the awaiting review label Jul 20, 2023
@AlexWaygood AlexWaygood assigned methane Jul 20, 2023
serhiy-storchaka
serhiy-storchaka reviewed Jul 20, 2023
View reviewed changes
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4 @serhiy-storchaka
Update Python/compile.c
dda0d86 
Co-authored-by: Serhiy Storchaka <[email protected]>
methane
methane approved these changes Jul 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 21, 2023
@methane methane added the skip news label Jul 21, 2023
@methane
methane merged commit 85ed1d2 into python:main Jul 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 21, 2023
@Eclips4
Eclips4 deleted the issue-106916 branch July 21, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@methane methane methane approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@methane methane

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Eclips4 @methane @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.