GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107162: Remove errcode.h header file by vstinner · Pull Request #107163 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jul 23, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rename Include/errcode.h to Include/internal/pycore_errcode.h.

  • Issue: C API: Remove Include/errcode.h header file #107162

📚 Documentation preview 📚: https://cpython-previews--107163.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from a team, lysnikolaou and pablogsal as code owners July 23, 2023 22:02
@bedevere-bot bedevere-bot added the awaiting core review label Jul 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 23, 2023
C API: Remove Include/errcode.h header file #107162
Closed
@vstinner

vstinner commented Jul 23, 2023

Copy link
Copy Markdown
Member Author

cc @pablogsal @lysnikolaou @serhiy-storchaka: see #107162 for the removal rationale.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
pythongh-107162: Remove errcode.h header file
0cef34e 
Rename Include/errcode.h to Include/internal/pycore_errcode.h.
@vstinner
vstinner force-pushed the remove_errcode_h branch from 384e99c to 0cef34e Compare July 23, 2023 22:35
serhiy-storchaka
serhiy-storchaka previously approved these changes Jul 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 24, 2023
@serhiy-storchaka
serhiy-storchaka self-requested a review July 24, 2023 05:18
serhiy-storchaka
serhiy-storchaka reviewed Jul 24, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a part of the C API. These codes are returned by PyRun_InteractiveOneFlags(). See Doc/c-api/veryhigh.rst.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka dismissed their stale review July 24, 2023 05:25

It is a part of the C API.

@bedevere-bot bedevere-bot added awaiting review and removed awaiting merge labels Jul 24, 2023
@vstinner

vstinner commented Jul 24, 2023

Copy link
Copy Markdown
Member Author

So this PR is wrong. I wrote PR #107177 to complete the comment instead.

Thanks @serhiy-storchaka for your review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Jul 24, 2023
@vstinner
vstinner deleted the remove_errcode_h branch July 24, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.