GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst by mattwang44 · Pull Request #107246 · python/cpython

Conversation

@mattwang44

@mattwang44 mattwang44 commented Jul 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I found the following message when building 3.11 doc:

Warning, treated as error:
'statement' is deprecated for index entries (from entry 'statement: import'). Use 'pair: statement; import' instead.

It's part of sphinx-doc/sphinx#11412 and was released with sphinx 7.1.0 yesterday.

@AA-Turner resolved most issues in #104162 (and its 3.11 backport PR is #104163). However, imp module was removed in 3.12 before that and the old index directive in library/imp.rst seems to be omitted.

  • Issue: Docs use deprecated Sphinx .. index:: entries #97950

📚 Documentation preview 📚: https://cpython-previews--107246.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Docs use deprecated Sphinx .. index:: entries #97950
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 25, 2023
@mattwang44
mattwang44 force-pushed the old-index-directives-in-library-imp branch from d1f419e to 9158f63 Compare July 25, 2023 14:15
@mattwang44 mattwang44 changed the title GH-97950: Use new-style index directive (Doc/library/[email protected]) GH-97950: Use new-style index directive in Doc/library/[email protected] Jul 25, 2023
@mattwang44 mattwang44 changed the title GH-97950: Use new-style index directive in Doc/library/[email protected] [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst Jul 25, 2023
@mattwang44 mattwang44 changed the title [3.11] GH-97950: Use new-style index directive in Doc/library/imp.rst [3.11] GH-97950: Fix old-style index directive in Doc/library/imp.rst Jul 25, 2023
@mattwang44
Use new-style index directive ('statement') - library/imp
7c3d6ae
@mattwang44
mattwang44 force-pushed the old-index-directives-in-library-imp branch from 9158f63 to 7c3d6ae Compare July 26, 2023 02:26
AA-Turner
AA-Turner approved these changes Jul 26, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jul 26, 2023
@AA-Turner

AA-Turner commented Jul 26, 2023

Copy link
Copy Markdown
Member

cc: @hugovk @ezio-melotti
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
hugovk
hugovk approved these changes Jul 26, 2023
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 26, 2023
@hugovk
hugovk merged commit 9fa44d7 into python:3.11 Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @mattwang44 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned hugovk Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Sorry, @mattwang44 and @hugovk, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 9fa44d7a3045f4571e2cabd53a1cc0f16a0f3723 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jul 26, 2023

Copy link
Copy Markdown
Member

Ignore those two Miss Islington messages, this obviously doesn't need back porting to 3.12 and 3.11 branches because this went straight to 3.11 only.

Thanks again!
mattwang44 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk removed needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 26, 2023
@hugovk hugovk removed their assignment Jul 26, 2023
@mattwang44
mattwang44 deleted the old-index-directives-in-library-imp branch July 26, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mattwang44 @AA-Turner @miss-islington @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.