GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107253: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT by serhiy-storchaka · Pull Request #107254 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Use Py_T_OBJECT_EX instead of _Py_T_OBJECT #107253

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka added 2 commits July 25, 2023 16:57
@serhiy-storchaka
WIP: Try to use Py_T_OBJECT_EX instead of _Py_T_OBJECT
fc57e75
@serhiy-storchaka
Revert some replaces to fix tests.
cb32733
@serhiy-storchaka serhiy-storchaka added the DO-NOT-MERGE label Jul 25, 2023
@serhiy-storchaka
serhiy-storchaka requested review from 1st1, berkerpeksag, corona10, erlend-aasland, iritkatriel, markshannon and rhettinger as code owners July 25, 2023 16:37
@bedevere-bot bedevere-bot added the awaiting core review label Jul 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 25, 2023
Use Py_T_OBJECT_EX instead of _Py_T_OBJECT #107253
Closed
@serhiy-storchaka
Try to fix tests on Windows.
2195315
@rhettinger
rhettinger removed their request for review July 25, 2023 20:05
@encukou

encukou commented Nov 28, 2023

Copy link
Copy Markdown
Member

This is a behaviour change. It may break existing users.
It's OK to do the change in individual cases where the existing behaviour is problematic, but changing all the occurrences is just asking for trouble.
These are the cases that don't break tests, but IMO in many cases that means the tests are inadequate :)

Would you be OK closing this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 13, 2026
@encukou encukou closed this Apr 15, 2026
@serhiy-storchaka
serhiy-storchaka deleted the Py_T_OBJECT_EX branch July 1, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review DO-NOT-MERGE stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.