GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101524: Only Use Public C-API in the _xxsubinterpreters Module by ericsnowcurrently · Pull Request #107359 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jul 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The _xxsubinterpreters module should not rely on internal API. Some of the functions it uses were recently moved there however. Here we move them back (and expose them properly).

  • Issue: Maybe Drop "channels" from _xxsubinterpreters #101524

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 5 commits July 27, 2023 13:27
@ericsnowcurrently
Restore PyUnstable_InterpreterState_GetMainModule() to the public API.
3cbb14b
@ericsnowcurrently
Restore PyUnstable_AtExit() to the public API.
40f4d3d
@ericsnowcurrently
Revert "pythongh-106320: Remove private _PyInterpreterID C API (pytho…
a801680 
…n#107053)"

This reverts commit 22422e9.
@ericsnowcurrently
Restore PyInterpreterID_*() to the public API.
3c1a0ff
@ericsnowcurrently
Do not require the internal API for _xxsubinterpreters.
71e88b0
@ericsnowcurrently ericsnowcurrently added the skip news label Jul 27, 2023
@ericsnowcurrently
ericsnowcurrently requested a review from a team as a code owner July 27, 2023 20:04
@bedevere-bot bedevere-bot mentioned this pull request Jul 27, 2023
Maybe Drop "channels" from _xxsubinterpreters #101524
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 27, 2023
@ericsnowcurrently
ericsnowcurrently removed the request for review from a team July 27, 2023 20:04
@ericsnowcurrently
Keep ignoring the type.
72c0468
@ericsnowcurrently

ericsnowcurrently commented Jul 27, 2023

Copy link
Copy Markdown
Member Author

FYI, 3.12 was fixed separately.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 8bdae14 into python:main Jul 27, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 27, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-_xxsubinterpreters-only-public-api branch July 27, 2023 21:30
@ericsnowcurrently ericsnowcurrently mentioned this pull request Aug 8, 2023
Add Documentation for C-API Used by the _xxsubinterpreters Module #107784
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.