GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106368: Argument clinic: Fix minor bug in `state_modulename_name` by AlexWaygood · Pull Request #107387 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Jul 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cls on this line could be None, which causes the test case I'm adding in this PR to fail with AttributeError: 'NoneType' object has no attribute 'functions' on the main branch.

cpython/Tools/clinic/clinic.py

Line 4713 in 0aa58fa

print("cls. functions", cls.functions)

(This failure path is currently not covered by any test cases, as far as I can tell. The bug is flagged by mypy if you add type annotations to the last remaining untyped function in clinic.py, _module_and_class().)

@erlend-aasland: this is another one that could be backported, since it's technically a bugfix, but to me feels minor enough to not be worth it.

  • Issue: Increase Argument Clinic test coverage #106368

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@AlexWaygood
Argument clinic: Fix minor bug in state_modulename_name
acfd270
@AlexWaygood AlexWaygood added the skip news label Jul 28, 2023
@AlexWaygood
AlexWaygood requested a review from erlend-aasland as a code owner July 28, 2023 11:34
@bedevere-bot bedevere-bot added the awaiting core review label Jul 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 28, 2023
Increase Argument Clinic test coverage #106368
Closed
@AlexWaygood

This comment was marked as outdated.

Sign in to view
serhiy-storchaka
serhiy-storchaka reviewed Jul 28, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Address Serhiy's review
d4b31b4
@AlexWaygood
AlexWaygood requested a review from serhiy-storchaka July 28, 2023 16:33
serhiy-storchaka
serhiy-storchaka approved these changes Jul 28, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 28, 2023
@AlexWaygood
AlexWaygood merged commit ecc05e2 into python:main Jul 28, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 28, 2023
@AlexWaygood
AlexWaygood deleted the minor-modulename-bugs branch July 28, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.