GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107424: avoid using lambda functions in ``textwrap.indent()`` by picnixz · Pull Request #107426 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jul 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As mentioned by #107374 (comment), avoiding the use of a lambda function when no predicate is specified is expected to improve the performances.

The benchmarks reported on the issue corroborate this assumption. However, I would like to know if this is only because my laptop is dying (caching .append calls do not seem to help however).

I am waiting for changes to be verified before creating a NEWS entry (should I create it in conjunction to the already created one by @methane ?)

  • Issue: Optimize textwrap.indent a bit more. #107424

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz picnix_
optimize textwrap.indent() (python#107424)
3439066
@ghost

ghost commented Jul 29, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jul 29, 2023
Optimize textwrap.indent a bit more. #107424
Closed
@bedevere-bot bedevere-bot added the awaiting review label Jul 29, 2023
@bedevere-bot

bedevere-bot commented Jul 29, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane

methane commented Jul 30, 2023

Copy link
Copy Markdown
Member

Our goal is not only maximize performance. And textwrap.indent() is not performance critical for most applications as far as I know.

In #107374, I made the code slightly simpler by removing generator.
On the other hand, this change makes maintenance cost little higher. We need to review and test the case for predicate is passed.
That's why I didn't incude this change in my PR.

(caching .append calls do not seem to help however).

Yes. It is old technique. Recent Python has little method call overhead. So append = L.append before loop has only little venefit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane methane closed this Jul 30, 2023
@picnixz
picnixz deleted the gh-107424-optimize-textwrap-indent branch July 30, 2023 07:13
@picnixz picnixz mentioned this pull request Mar 31, 2025
gh-107369: Optimise textwrap.indent() #131923
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @bedevere-bot @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.