GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104909: Move unused cache entries from uops to macros by gvanrossum · Pull Request #107444 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jul 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There's no need to use a dummy uop to skip unused cache entries. The macro syntax lets you write unused/1 instead.

Similarly, move unused/5 from op _LOAD_ATTR_INSTANCE_VALUE to macro LOAD_ATTR_INSTANCE_VALUE.

  • Issue: Split opcodes into micro-ops #104909

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Drop _SKIP_CACHE op in favor of unused/1
b1159ce
@gvanrossum
gvanrossum requested a review from markshannon July 29, 2023 21:02
@bedevere-bot bedevere-bot added the awaiting core review label Jul 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 29, 2023
Split opcodes into micro-ops #104909
Closed
@gvanrossum
Move unused/5 from op _LOAD_ATTR_INSTANCE_VALUE to macro
757a46c
@gvanrossum gvanrossum added the skip news label Jul 29, 2023
markshannon
markshannon approved these changes Jul 31, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 31, 2023
@gvanrossum
gvanrossum merged commit 5eb80a6 into python:main Jul 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 31, 2023
@gvanrossum
gvanrossum deleted the rm-skip-cache-uop branch July 31, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.