GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-104584: Fix incorrect uoperands by brandtbucher · Pull Request #107513 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jul 31, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There's currently an off-by-one error during trace construction that causes incorrect values to be loaded from the inline caches.

This fix results in a significant reduction in deoptimization events, and a dramatic improvement in our ability to stay on trace!

  • Issue: Pluggable optimizer API #104584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 3 commits July 29, 2023 21:59
@brandtbucher
Fix off-by-one error
f274c05
@brandtbucher
blurb add
2c2b847
@brandtbucher
fixup
e189369
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 31, 2023
@brandtbucher
brandtbucher requested a review from gvanrossum July 31, 2023 20:43
@brandtbucher brandtbucher self-assigned this Jul 31, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jul 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 31, 2023
Pluggable optimizer API #104584
Closed
gvanrossum
gvanrossum approved these changes Jul 31, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I'm surprised this never showed when I tested things. I guess it just caused excessive cache failures. :-(

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 31, 2023
@brandtbucher
brandtbucher enabled auto-merge (squash) July 31, 2023 21:16
@brandtbucher
brandtbucher merged commit 5e584eb into python:main Jul 31, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brandtbucher @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.